[S] Change in osmo-hnbgw[master]: nft_kpi: add udp/2152 filtering rules separately - gerrit-log

24 Dec 2025


      Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email )
Change subject: nft_kpi: add udp/2152 filtering rules separately
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752/comment/517bd30b_2ddbadaf?us... :
PS3, Line 328: static int do_add_chain(bool uplink)
...
I particularly agree with pespin's second comment. […]
I've addressed the second comment, but still kept the function to reduce code duplication. The chain name and hook are now passed as arguments. Hopefully, the new approach looks cleaner.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd
Gerrit-Change-Number: 41752
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 24 Dec 2025 22:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de