Attention is currently required from: neels.

laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email )

Change subject: [4/6] personalization: refactor Pin, Adm ......................................................................

Patch Set 3: -Code-Review

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39744/comment/7ef4d6b0_4e20244d?usp=ema... : PS3, Line 408: return (pe for pe in l if pe.type == wanted_type)

No! […]

* I think from an ISO7816 and UICC point of view it's sadly not correct to limit to MF. The MF has PINs, and each application on a card (e.g. USIM or ISIM application on a typical telecom card) may have its own set of application PINs. I haven't really seen any use of that, though. And I'm not sure what eSIM profiles support in that regard, please check the SAIP spec. * Regarding the ProfileElementList: I think we have to distinguish an acutal plain list in the python sense, from the decoded asn.1 structures of the SAIP PEList definition. If you come up with a better way to name and/or logically represent those two in the code: be my guest. For sure it would be elegant not having to reimplement things.