Attention is currently required from: osmith, laforge, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 )
Change subject: Check VTY config against features reported by BTS ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/33f56416_35dee4ad PS6, Line 502: if (!bts_gprs_mode_is_compat(bts, bts->gprs.mode)) { && instead of nested if?
File src/osmo-bsc/bts_osmobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/ab7009b7_0617aac9 PS6, Line 208: /* Adjust bts_init/bts_model_init in OsmoBTS to report new features. i wonder what this comment attempts to say, sounds like legacy that we can drop?
-
neels