Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38524?usp=email )
Change subject: Refactor tun_t fields and alloc APIs
......................................................................
Patch Set 1:
(1 comment)
File lib/tun.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38524/comment/8fce2ad7_d01ffb50?usp... :
PS1, Line 111: tun->devname[IFNAMSIZ - 1] = 0;
This is redundant because: […]
I'll submit this change in a follow-up commit, since it's really orthogonal to all the refactoring in here (I'm simply moving the code chunk in this commit).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/38524?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic71f91c62cd5bd48c6d35534eaac2091e4c69735
Gerrit-Change-Number: 38524
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 25 Oct 2024 13:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de