Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33290 ) Change subject: validate RSL "channel rate and type" against VGCS/VBS flags ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33290/comment/cca8106f_d4195fc2 PS2, Line 782: int bts_supports_cm(const struct gsm_bts *bts, iiuc this function actually returns a bool? do you mind submitting an extra patch returning bool and using true/false? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e7f65b44cef6e2f7ad4f152f80a1686a4f511e3 Gerrit-Change-Number: 33290 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 11:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment