Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 )

Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ......................................................................

Patch Set 7:

(2 comments)

Patchset:

PS7: I think this is a good idea, but there are indeed a lot of applications that have problems. Especially event names like XXXX.ind or XXXX.req are used quite often. I would suggest to replace the dot with a '-'.

File src/fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/61fc3595_0879039d PS7, Line 296: "state name '%s'\n", states[i].name); I think this is problematic. osmo_fsm_register() may be called before the log is set up. Maybe we should consider using printf here?