Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34310?usp=email ) Change subject: l1gprs/l1ctl: Decouple RTS.ind from DL_BLOCK.ind ...................................................................... Patch Set 1: (6 comments) File src/host/layer23/src/common/l1ctl.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/7f93ee98_5517c428 PS1, Line 1007: Rx GPRS DL block copy-paste, `Rx GPRS RTS.ind`? (also print USF?) File src/host/layer23/src/modem/grr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/d9518134_8a95afbb PS1, Line 480: Do not send RTS.ind if we got PTCCH/D l1gprs should be smart enough to not send RTS.ind for PTCCH now? File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/f6eff207_d5672ef7 PS1, Line 634: /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus cosmetic: comment alignment File src/host/virt_phy/src/virt_prim_pdch.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/b44063ce_818900ea PS1, Line 79: usf You need to assign `0xff` by default, because `l1gprs_handle_dl_block_ind()` may return early. https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/e4e3e95a_aa096d9c PS1, Line 101: /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus cosmetic: comment alignment File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/d63b5e06_5d391105 PS1, Line 699: l1gprs_check_pending_tbfs Just to be sure, is it ok that we still call it here? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1494e0aac7555f6e01b4b435b77140afc42c098e Gerrit-Change-Number: 34310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 15:32:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment