Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35625?usp=email )

Change subject: gsm_04_08_gprs.h: Introduce packed struct gsm48_pdp_address ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:

https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/1cf9eba3_e3eaab82 PS1, Line 316: uint8_t organization:4, /* enum gsm48_pdp_type_org */ alignment issues

https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/98fc46f0_83cc1f32 PS1, Line 337: uint32_t v4; likewise, alignment issues

https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/db018948_54337a8b PS1, Line 340: ietf So the total size of this union is 20 (determined by size of `v4v6`). It's not a problem when parsing a Packet Data Protocol Address IE, but may be a problem when encoding it with either `PDP_TYPE_N_IETF_IPv4` or `PDP_TYPE_N_IETF_IPv6`, because doing `msgb_put(msg, sizeof(struct gsm48_pdp_address))` is only valid for `PDP_TYPE_N_IETF_IPv4v6`.