Attention is currently required from: lynxis lazus, pespin.

View Change

3 comments:

• File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:

  • Patch Set #1, Line 316: uint8_t organization:4, /* enum gsm48_pdp_type_org */

    alignment issues

  • Patch Set #1, Line 337: uint32_t v4;

    likewise, alignment issues

  • Patch Set #1, Line 340: ietf

    So the total size of this union is 20 (determined by size of `v4v6`). It's not a problem when parsing a Packet Data Protocol Address IE, but may be a problem when encoding it with either `PDP_TYPE_N_IETF_IPv4` or `PDP_TYPE_N_IETF_IPv6`, because doing `msgb_put(msg, sizeof(struct gsm48_pdp_address))` is only valid for `PDP_TYPE_N_IETF_IPv4v6`.

To view, visit change 35625. To unsubscribe, or for help writing mail filters, visit settings.