Attention is currently required from: arehbein, pespin, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33194 )
Change subject: examples: Use new stream API in {ipa-,}stream-{client,server} ......................................................................
Patch Set 14: Code-Review+1
(6 comments)
File examples/ipa-stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/408ad00e_4def7aa8 PS1, Line 161: LOGL_DEBUG
Ack
Done
File examples/ipa-stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/cdc46986_2a1b1243 PS13, Line 167: conn = osmo_stream_cli_create2(tall_test, "ipa test client");
underscores instead of spaces? We'll end up logging that name at some point, spaces are not nice as […]
Done
File examples/ipa-stream-server.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/c928e255_eaa2490a PS1, Line 94: LOGL_DEBUG
unrelated change.
Done
File examples/ipa-stream-server.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/70ce9303_b3883901 PS13, Line 78: conn = osmo_stream_srv_create2(tall_test, "srv link", srv, fd, NULL);
same, no spaces in name?
Done
File examples/stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/42b6d8f7_6e38e65a PS13, Line 107: conn = osmo_stream_cli_create2(tall_test, "stream client");
no spaces in name.
Done
File examples/stream-server.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/11b4351b_72b0c65e PS13, Line 72: conn = osmo_stream_srv_create2(tall_test, "stream server", srv, fd, NULL);
no spaces in mame.
Done