Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37543?usp=email )
Change subject: pySim-shell: add "fsdump" command ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS1:
I noticed we actually forget to dump the DF and ADD, but those also have FCP with security attribute […]
Done
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37543/comment/9436f00b_df895119 PS1, Line 731: # the EF we want to export. To maintain consistency we will then
tabs vs spaces
Done
https://gerrit.osmocom.org/c/pysim/+/37543/comment/0eff120f_c3edf22c PS1, Line 784: result[0])
don't you need to do `str()` like above?
Done
https://gerrit.osmocom.org/c/pysim/+/37543/comment/bf83e2dc_21fe430c PS1, Line 790: else
cosmetic: `else` is not needed after `break` or `return`
Done
https://gerrit.osmocom.org/c/pysim/+/37543/comment/384c391e_c064698c PS1, Line 852: self.export_ef(opts.filename, context, **kwargs_export)
Did you mean fsdump_ef here?
Done
-
laforge