pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33983 ) Change subject: WIP: Assume MultiSlot Class 1 if unknown ...................................................................... WIP: Assume MultiSlot Class 1 if unknown Until now, if timeslot resources where being allocated for an MS for which its msclass is not known, msclass=12 was being selected. While it's true that msclass=12 is quite a usual one implemented by phones (Rx=4, Rx=4, Sum=5), some MS implementations may not support such modes. As a result, if the PCU allocates a TBF for an MS which its msclass is not known (eg. because it used 1-phase access aka no Pkt Res Req), then a minimal msclass=1 must be assumed. Otherwise, it may assign more multislots than the MS can handle, and will work incorrectly since an amount of RLC/MAC blocks won't be sent/received properly. Change-Id: If80fdd793db7dad029faa83dbf980ffc4959e2e5 --- M src/mslot_class.h 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/33983/1 diff --git a/src/mslot_class.h b/src/mslot_class.h index d273cad..aa2214e 100644 --- a/src/mslot_class.h +++ b/src/mslot_class.h @@ -30,7 +30,8 @@ #define MS_C 252 /* 1 with hopping, 0 without (change Tx to Rx)*/ #define MS_TO 251 /* 31 symbol periods (this can be provided by a TA offset, i.e. a minimum TA value) */ -#define DEFAULT_MSLOT_CLASS 12 +/* If Multislot Class is not known, use ms_class=1: Rx=1 Tx=1 Sum=2 */ +#define DEFAULT_MSLOT_CLASS 1 #define NO_FREE_TFI 0xffffffff -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If80fdd793db7dad029faa83dbf980ffc4959e2e5 Gerrit-Change-Number: 33983 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange