Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31031 ) Change subject: Add more L1 signals to common part ...................................................................... Patch Set 3: (2 comments) File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/bd5acfc7_05fcdfdd PS1, Line 245: S_L_INP_LINE_LOS, : S_L_INP_LINE_NOLOS, : S_L_INP_LINE_AIS, : S_L_INP_LINE_NOAIS, : S_L_INP_LINE_RAI, : S_L_INP_LINE_NORAI, : S_L_INP_LINE_SLIP_RX, : S_L_INP_LINE_SLIP_TX, indeed, we still don't have a description of how this signal works. The other conditions are all well-known and it's clear whar LOS or NOLOS means, and when it's triggered. But when is the SA_BITS signal triggered? Every time the SA bits change in the received bitstream? https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/c20c74a2_d3da6472 PS1, Line 370: uint8_t sa_bits; Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I295dc340d3d3a7cbb5aba5afe807746acbcde33f Gerrit-Change-Number: 31031 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 11:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment