Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email ) Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq ...................................................................... Patch Set 1: (2 comments) File library/GTPv2_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/bbd82a13_d865… PS1, Line 751: 6 Sorry previous comment want ment for the other discussion. "why replace it with ?" because the RAT type really changes depending on where you use/expect the message. For instnace I'm expecting 5 (WLAN) in my current tests. BTW, I believe this tr template was not yet used anywhere because it had some bugs which I'm now fixing with the patchset; a more generic template was being used instead. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/984f96ba_1aa8… PS1, Line 743: ? I don't even know why that value was set there tbh, but makes no sense to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 Gerrit-Change-Number: 34822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 15:03:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment