Attention is currently required from: osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email )

Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq ......................................................................

Patch Set 1:

(2 comments)

File library/GTPv2_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/bbd82a13_d8656... PS1, Line 751: 6

I don't even know why that value was set there tbh, but makes no sense to me.

Sorry previous comment want ment for the other discussion.

"why replace it with ?" because the RAT type really changes depending on where you use/expect the message. For instnace I'm expecting 5 (WLAN) in my current tests.

BTW, I believe this tr template was not yet used anywhere because it had some bugs which I'm now fixing with the patchset; a more generic template was being used instead.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/984f96ba_1aa8c... PS1, Line 743: ?

shouldn't the previous default '012a'O be here?

I don't even know why that value was set there tbh, but makes no sense to me.