Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 )

Change subject: doxygen API documentation for libosmo-e1d ......................................................................

Patch Set 3:

(8 comments)

File Doxyfile.in:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/327c7531_cb86ba3b PS3, Line 834: # It is adviced to generate a default header using "doxygen -w html 'adviced' may be misspelled - perhaps 'advised'?

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/bb759f38_c7555041 PS3, Line 1488: # TAGFILES = trailing whitespace

File include/osmocom/e1d/proto.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/9c6b5bfe_5dbddb5b PS3, Line 42: * filter: intf (required), line (optional); * in: n/a; out: array of osmo_e1dp_line_info */ please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/915c12ee_5d424343 PS3, Line 112: uint16_t magic; /*< magic value (E1DP_MAGIC) */ please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/4ac836a0_4168125f PS3, Line 113: uint16_t len; /*< length of message (octets) */ please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/ba8d18e1_535da282 PS3, Line 117: uint8_t line; /*< E1 line number (or E1DP_INVALID) */ please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/5f49cb6f_7a687ef1 PS3, Line 118: uint8_t ts; /*< timeslot number (or E1DP_INVALID) */ please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-778): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/8b5a8460_04b83231 PS3, Line 124: uint8_t n_lines; /*< number of E1 lines within this interface */ please, no space before tabs