Attention is currently required from: fixeria. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29386 )
Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-tetra/+/29386/comment/1749fae9_1ea77205 PS1, Line 7: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame
Would be good to see the motivation for this change in the commit message. […]
As you can see in the tetra_tdma_time struct definition comments in tetra_tdma.h, it is always supposed to be in this range. Also, tetra_burst_sync_in increments the timeslot number when synchronized, ultimately using the function normalize_tn in tetra_tdma.c which also only works properly on the uses the 1-4 range.