keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33890 ) Change subject: SMPP: Fix Memory leak in deliver_to_esme() ...................................................................... SMPP: Fix Memory leak in deliver_to_esme() After we call build_tlv, in this case via append_tlv_u16, we must call destroy_tlv after we are finished with it. Change-Id: Ic2abcbe78cf7cf7b6ce36fe09aa9b4f8daee973f --- M src/libsmpputil/smpp_msc.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/33890/1 diff --git a/src/libsmpputil/smpp_msc.c b/src/libsmpputil/smpp_msc.c index fed5858..cf17540 100644 --- a/src/libsmpputil/smpp_msc.c +++ b/src/libsmpputil/smpp_msc.c @@ -788,6 +788,7 @@ sms->msg_ref); ret = smpp_tx_deliver(esme, &deliver); + destroy_tlv(deliver.tlv); if (ret < 0) return ret; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic2abcbe78cf7cf7b6ce36fe09aa9b4f8daee973f Gerrit-Change-Number: 33890 Gerrit-PatchSet: 1 Gerrit-Owner: keith &lt;keith(a)rhizomatica.org&gt; Gerrit-MessageType: newchange