Attention is currently required from: Hoernchen, laforge.
osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470?usp=email )
Change subject: clang-format ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS2:
I'd say this needs some more explanation and possibly integration? What is the purpose of the file? […]
* pre-commit hook is there now * server side: needs clang-format added to the docker container first: https://gerrit.osmocom.org/c/docker-playground/+/39763, I can adjust contrib/jenkins.sh in a follow-up patch after both are merged so we don't need to block here
File contrib/pre-commit-hook:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470/comment/562950a5_998dabdb... : PS3, Line 1: #!/usr/bin/env bash maybe make this executable?