Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email )
Change subject: CSD: implement half-rate modes correctly ......................................................................
Patch Set 1:
(6 comments)
File src/common/l1sap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465): https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/3e93bb42_b18a51dc?usp=... : PS1, Line 2064: const uint8_t *data, uint16_t data_len) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465): https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/1510371f_47b52466?usp=... : PS1, Line 2064: const uint8_t *data, uint16_t data_len) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465): https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/9de6dd21_398f2fe8?usp=... : PS1, Line 2092: const uint8_t *data, uint16_t data_len) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465): https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/5de453ae_a4b829da?usp=... : PS1, Line 2092: const uint8_t *data, uint16_t data_len) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465): https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/47c1f6de_38b2229d?usp=... : PS1, Line 2126: const uint8_t *data, uint16_t data_len) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465): https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/60fe7884_d97e4f6a?usp=... : PS1, Line 2126: const uint8_t *data, uint16_t data_len) please, no space before tabs