Change in libosmocore[master]: netdev: Fix compilation building with --disable-libmnl - gerrit-log

25 Jan 2023


      Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31071 )
Change subject: netdev: Fix compilation building with --disable-libmnl
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/8630c8d1_68ce5e43 
PS1, Line 845:
...
I would prefer to keep them below, since the netns stuff is totally orthogonal to using ioctl or lib […]
But you're only doing the netns enter/exit to (not) call the mnl function?
In any case fine with me.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31071
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I62bdea075afb9e0cc2bbcec6dd3a930e8f7bbc40
Gerrit-Change-Number: 31071
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 25 Jan 2023 16:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment