[S] Change in osmo-ttcn3-hacks[master]: msc: f_expect_paging(): fix by_tmsi arg - gerrit-log

14 Apr 2024

Attention is currently required from: laforge, neels.

fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email )

Change subject: msc: f_expect_paging(): fix by_tmsi arg
......................................................................

Patch Set 2:

(1 comment)

File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455/comment/dcabf1d2_5b9b… 
PS2, Line 1360: function f_expect_paging(template OCT4 tmsi := *)
...
  Not blocking; But this patch breaks one paradigm of
this function: see below how we use g_pars.imsi.
 Now this is not using g_pars.tmsi as would be logical, but the caller is passing a TMSI
explicitly. 
Yes, this is an inconsistency that I acknowledge.

...
  This is the reason why i all the time and still and
always will think a boolean is semantically the right choice. To fix it, you'd also
have to make the imsi an argument that is passed in and not taken from g_pars. 
This is an option, but that would require all callers of this function to pass IMSI
(`g_pars.imsi`) implicitly. Unlike with TMSI, I hardly see a scenario in which one would
want to pass anything else than `g_pars.imsi`. So by doing that we would loose more than
win.

As a compromis, I propose the following:

```
function f_expect_paging_tmsi(template OCT4 tmsi := *) { ... }
function f_expect_paging() {
    f_expect_paging_tmsi(g_pars.tmsi);
}
```

This way we would be using `g_pars.imsi` and `g_pars.tmsi` by default, but at the same
time allow the API user to overwrite the TMSI expectations.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a
Gerrit-Change-Number: 36455
Gerrit-PatchSet: 2
Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Sun, 14 Apr 2024 11:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-MessageType: comment