Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email )
Change subject: fix usb usb reset handling by delayed soft reset ......................................................................
Patch Set 1:
(2 comments)
File sysmoOCTSIM/hpl/core/hpl_init.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/5bec0865_315... : PS1, Line 57: // _osc32kctrl_init_sources(); : // _oscctrl_init_sources(); : // _mclk_init(); : // #if _GCLK_INIT_1ST : // _gclk_init_generators_by_fref(_GCLK_INIT_1ST); : // #endif : // _oscctrl_init_referenced_generators(); why are we just commenting this out rather than removing it?
File sysmoOCTSIM/main.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/f32229ee_bf9... : PS1, Line 579: if(delayed_usb_reset) I'm wondering why we suddenly format "if" as if it was a function. Some of the code below seems to indicate this was alreay done earlier :/