Attention is currently required from: laforge, pespin, fixeria.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32181 )
Change subject: tests: Add initial osmo_io tests ......................................................................
Patch Set 9:
(2 comments)
File tests/osmo_io/osmo_io_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/333da413_f7fe872a PS2, Line 41: void *ctx = NULL;
static? not critical in a test, though
Done
File tests/osmo_io/osmo_io_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/5a6ee814_96806226 PS3, Line 54: printf("%s: Write returned rc=%d\n", osmo_iofd_get_name(iofd), rc);
so in read_cb you have to free msg, but in write_cb you don't?
Correct. I'm only passing msg here because the callback might want to know which message was sent/ had an error. It should also be const struct msgb?
-
daniel