Attention is currently required from: laforge, pespin, fixeria.

View Change

2 comments:

• File tests/osmo_io/osmo_io_test.c:

  • Patch Set #2, Line 41: void *ctx = NULL;

    static? not critical in a test, though

    Done

• File tests/osmo_io/osmo_io_test.c:

  • Patch Set #3, Line 54: printf("%s: Write returned rc=%d\n", osmo_iofd_get_name(iofd), rc);

    so in read_cb you have to free msg, but in write_cb you don't?

    Correct. I'm only passing msg here because the callback might want to know which message was sent/ had an error. It should also be const struct msgb?

To view, visit change 32181. To unsubscribe, or for help writing mail filters, visit settings.