[M] Change in osmo-pcu[master]: pcu_l1_if: get rid of strange paging group calculation - gerrit-log

8 Mar 2023


      Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31650 )
Change subject: pcu_l1_if: get rid of strange paging group calculation
......................................................................
Patch Set 8:
(1 comment)
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31650/comment/de59f59d_ba350a60 
PS7, Line 272: 	/* Without IMSI the BTS/BSC is unable to calculate the paging group */
...
You are changing the behavior here I think!! […]
Yes, that is indeed a problem. I have now changed it so that it prepends "000" when the IMSI is not present or the IMSI is shorter then 3 digits. This still excludes IMSIs shorter then 3 digits but I think we will either have no IMSI at all or the full IMSI in memory so we can safely ignore those corner cases.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31650
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40d7fc14c9591b3de091e425faaf325421c70a0e
Gerrit-Change-Number: 31650
Gerrit-PatchSet: 8
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 07 Mar 2023 17:41:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment