Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email ) Change subject: LAPDm: Add support for RTS based polling ...................................................................... Patch Set 8: (4 comments) File include/osmocom/gsm/lapdm.h: https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/b0832641_9986bde9 PS8, Line 38: uint32_t t200_timeout; /*!< T200 timeout frame number */ also breaks ABI, see my comment regarding TODO-RELEASE in previous patch File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/c282cb8a_3c223707 PS8, Line 355: uint8_t chan_nr, uint8_t link_id, uint8_t pad) unrelated cosmetic change? https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/f906a1a3_8388f7bd PS8, Line 1617: void lapdm_entity_set_t200_fn(struct lapdm_entity *le, int *t200_fn) this misses explanation of what the int t200_fn array is supposed to contain. Also: why is it signed and not unsigned? can thre ever be negative T200? https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/a154dd2e_20029181 PS8, Line 1625: T200 FN timer The reader should be educated what is a "T200 FN timer"? What are the expected argument types? In which unit? Can they be NULL? ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ebe83f829d7751ea9de1d90eb478c7a628db64c Gerrit-Change-Number: 34986 Gerrit-PatchSet: 8 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Comment-Date: Mon, 13 Nov 2023 18:28:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment