Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34987?usp=email ) Change subject: LAPDm: Add an extra queue for UI frames ...................................................................... Patch Set 8: (2 comments) File include/osmocom/gsm/lapdm.h: https://gerrit.osmocom.org/c/libosmocore/+/34987/comment/94492213_f093e230 PS8, Line 37: struct llist_head tx_ui_queue; /*!< UI frames to L1 */ TODO-RELEASE due to ABI breakage File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/34987/comment/4d7929af_b1a62151 PS8, Line 295: while ((msg = msgb_dequeue(&dl->tx_ui_queue))) this function reimplements the msgb_queue_free() function which we already have in msgb.h of libosmocore. We should avoid duplicating code. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I00c8ee73be8b7c564a4dee3fca3e893484f567da Gerrit-Change-Number: 34987 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:30:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment