Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 )
Change subject: apply code review: refactor pfcp_endpoint API ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
You are improving the state ofn things halfway, since you implemented some API getters/setter for so […]
the pattern of a struct to pass user provided config is used in many other places. maybe it is apparent, i'm having difficulty accepting this code review... it feels a bit like the way i have done things for years is now considered wrong, and it is causing a lot of work on top of the pile of tasks i am trying to complete.
how about the 'bool more_items' way to ensure ABI compat, like used in libosmocore/include/osmocom/gsm/gsm0808.h