Attention is currently required from: dexter, laforge.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36974?usp=email )

Change subject: add contrib/es9p_client: Perform ES9+ client functions like LPA+eUICC ......................................................................

Patch Set 4:

(6 comments)

File contrib/es9p_client.py:

https://gerrit.osmocom.org/c/pysim/+/36974/comment/d9d258bd_b528f12a PS4, Line 40: manuall manually

https://gerrit.osmocom.org/c/pysim/+/36974/comment/3cb532af_e267fdb7 PS4, Line 46: subparsers.required = True

then argparse will display a nice usage error when it is missing. I recommend this over

``` else: sys.exit(2) ```

at the bottom of this file

https://gerrit.osmocom.org/c/pysim/+/36974/comment/2195419e_9ff753d9 PS4, Line 122: # TODO: verify server certificate against CI maybe print a note here, that these don't get verified? same at "# TODO: verify signature", "# TODO: verify transactionId", etc. below

https://gerrit.osmocom.org/c/pysim/+/36974/comment/5c6ead7c_1427e3e0 PS4, Line 138: 'sasAcreditationNumber': 'SYSMOCOM-TEST-1', should this be hardcoded here?

https://gerrit.osmocom.org/c/pysim/+/36974/comment/2c436087_e60e760e PS4, Line 236: #print(opts) debug leftover?

File pySim/esim/es8p.py:

https://gerrit.osmocom.org/c/pysim/+/36974/comment/80d0a3dd_78b849cf PS4, Line 233: sequenceOf88 sequenceOf86?