Attention is currently required from: dexter, laforge.

View Change

6 comments:

• File contrib/es9p_client.py:

  • Patch Set #4, Line 40: manuall

    manually

  • Patch Set #4, Line 46:

    subparsers.required = True

    then argparse will display a nice usage error when it is missing. I recommend this over

    ```
        else:
            sys.exit(2)
    ```

    at the bottom of this file

  • Patch Set #4, Line 122: # TODO: verify server certificate against CI

    maybe print a note here, that these don't get verified? same at "# TODO: verify signature", "# TODO: verify transactionId", etc. below

  • Patch Set #4, Line 138: 'sasAcreditationNumber': 'SYSMOCOM-TEST-1',

    should this be hardcoded here?

  • Patch Set #4, Line 236: #print(opts)

    debug leftover?

• File pySim/esim/es8p.py:

  • Patch Set #4, Line 233: sequenceOf88

    sequenceOf86?

To view, visit change 36974. To unsubscribe, or for help writing mail filters, visit settings.