Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332?usp=email )

Change subject: 5gc: Introduce tests for emergency services ......................................................................

Patch Set 1:

(2 comments)

File 5gc/C5G_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332/comment/0a1e85ba_0bc64... : PS1, Line 625: 11

From the comment above it looks like you expect '00'B?

I'll change the wording to "supported".

File 5gc/expected-results.xml:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332/comment/69084e6a_8a7b3... : PS1, Line 27: DTE

Why DTE? Can you make the testcases set a more meaningful verdict?

That's imho titan's fault for generating a DTE when reciving a message while expecting a non-matching one.

I don't really think it makes sense to spend time on this since it's not implemented in open5gs and once you run the test it's clear that it fails because open5gs doesn't announce support for the feature. This can be revisited once open5gs adds support for it, or whoever wants to develop the feture using this test.

I'm so far trying to cover as many procedures as possible to have all the needed infastructure in place, so it's easy to write new tests with more specific corner case scenarios later.