[M] Change in osmo-ggsn[master]: gtp: Rework gtp_resp() into gtp_resp_pdp() - gerrit-log

7 Jan 2025


      Attention is currently required from: daniel, laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email )
Change subject: gtp: Rework gtp_resp() into gtp_resp_pdp()
......................................................................
Patch Set 6:
(1 comment)
File gtp/gtp.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38933/comment/0256c280_5a1d729f?usp... :
PS6, Line 458: static int gtp_resp(struct gsn_t *gsn, union gtp_packet *packet, int len, struct sockaddr_in *peer, int fd,
...
it would probably be simplier to have a "uint32_t flow_teid" field which gets filled by the caller d […]
But you would loose the type check/length, which I like to have here.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Id9ff95e0e2a10a22e65ecf42b2a2b06a0f2d1a45
Gerrit-Change-Number: 38933
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 07 Jan 2025 14:06:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de