Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30960 )

Change subject: Move osmocom_ms to a separate file ......................................................................

Patch Set 5:

(3 comments)

File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/ac1d3af1_c2782c01 PS5, Line 3: #include <stdint.h> the above are unrelated changes sneaking into this patch

File src/host/layer23/src/common/main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/2d84c209_e1539ff4 PS5, Line 271: ms = osmocom_ms_alloc(l23_ctx);

The osmocom_ms_alloc() might return NULL - you should check for this.

(ack, IMO would suffice to OSMO_ASSERT(ms) either here or in osmocom_ms_alloc())

https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/a749b888_29b18707 PS5, Line 272: llist_add_tail(&ms->entity, &ms_list); i guess this llist_add would also belong in osmocom_ms_alloc()?