Attention is currently required from: pespin, msuraev.

View Change

3 comments:

• File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:

  • Patch Set #5, Line 3: #include <stdint.h>

    the above are unrelated changes sneaking into this patch

• File src/host/layer23/src/common/main.c:

  • Patch Set #5, Line 271: ms = osmocom_ms_alloc(l23_ctx);

    The osmocom_ms_alloc() might return NULL - you should check for this.

    (ack, IMO would suffice to OSMO_ASSERT(ms) either here or in osmocom_ms_alloc())

  • Patch Set #5, Line 272: llist_add_tail(&ms->entity, &ms_list);

    i guess this llist_add would also belong in osmocom_ms_alloc()?

To view, visit change 30960. To unsubscribe, or for help writing mail filters, visit settings.