Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code ......................................................................
Patch Set 5:
(24 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6279ba86_6e28ed1d?usp... : PS5, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/79960cd4_2a39ed06?usp... : PS5, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/98e6e96e_f7246662?usp... : PS5, Line 1551: else { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/62eb9c7d_ae95c246?usp... : PS5, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/762c0d9d_7bcaecd4?usp... : PS5, Line 1673: if (!foreign_ra && that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3128b37d_6153c6be?usp... : PS5, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/08b67be9_184d7321?usp... : PS5, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8aaf18d7_2f2f40d6?usp... : PS5, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ebf0a950_f3e63c35?usp... : PS5, Line 1964: } else { else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3b23a88e_4269e81c?usp... : PS5, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1d90c938_e31747ec?usp... : PS5, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b5965845_adef4b0b?usp... : PS5, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/cdf39cc0_3e051943?usp... : PS5, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/93d73898_a67a87d1?usp... : PS5, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0f34cf80_37d61140?usp... : PS5, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks
File src/sgsn/gprs_rau_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a0c327a8_106b8cf5?usp... : PS5, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8e7fd5bf_b48b59bc?usp... : PS5, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a40349e1_e9c1714b?usp... : PS5, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/76d424fa_40040adf?usp... : PS5, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/d82192cf_da4aeba0?usp... : PS5, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void)
File src/sgsn/mmctx.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b644e20a_8b846289?usp... : PS5, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/120d0871_ece19de4?usp... : PS5, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks
File src/sgsn/sgsn_main.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1548dde4_4c66d007?usp... : PS5, Line 360: [DVLR] = { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/f48c10e6_ffbb9d91?usp... : PS5, Line 364: }, please, no spaces at the start of a line
-
Jenkins Builder