Attention is currently required from: laforge, fixeria, daniel.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32181 )
Change subject: tests: Add initial osmo_io tests ......................................................................
Patch Set 4:
(4 comments)
File tests/osmo_io/osmo_io_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/31da7f08_cea315e2 PS4, Line 54: printf("%s: Write returned rc=%d\n",osmo_iofd_get_name(iofd), rc); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/05b4f770_08649d0f PS4, Line 95: for (int i = 0; i < 128; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/33b40a33_96e56b9c PS4, Line 146: for (int i = 0; i < 128; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/e5330bf9_1e1599ed PS4, Line 174: } adding a line without newline at end of file
-
Jenkins Builder