Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email )

Change subject: vlr: set the correct CN domain on GSUP messages ......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4: IMHO it makes more sense to have some kind of a wrapper function, like vlr_gsup_client_mux_tx() which then can set something like this at one single locatin in the code. That way it is not copy+pasted all over the place, and no single caller (also in the future) can forget to set this field correctly.

if it's a static function inside the vlr.c file the compiler will inline it and there's not even any function call overhead at runtime.