laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/27947 ) Change subject: server: Log connection establishment from bankd/client; warn on localhost ...................................................................... server: Log connection establishment from bankd/client; warn on localhost If a bankd connects to the server from 127.0.0.0/8, then clients will not be able to reach it unless they also run on localhost. Warn the user. Change-Id: I5446752961b039dad54aec981c1df4814779f765 --- M src/server/rspro_server.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/47/27947/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 6514f80..6c01c0a 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -123,6 +123,12 @@ const ConnectClientReq_t *cclreq = NULL; const ConnectBankReq_t *cbreq = NULL; RsproPDU_t *resp = NULL; + char ip_str[INET6_ADDRSTRLEN]; + char port_str[6]; + + /* remote IP and port */ + osmo_sock_get_ip_and_port(conn->peer->ofd.fd, ip_str, sizeof(ip_str), + port_str, sizeof(port_str), false); switch (event) { case CLNTC_E_CLIENT_CONN: @@ -161,6 +167,7 @@ osmo_fsm_inst_update_id_f(conn->keepalive_fi, "C%u:%u", conn->client.slot.client_id, conn->client.slot.slot_nr); + LOGPFSML(fi, LOGL_INFO, "Client connected from %s:%s\n", ip_str, port_str); resp = rspro_gen_ConnectClientRes(&conn->srv->comp_id, ResultCode_ok); client_conn_send(conn, resp); osmo_fsm_inst_state_chg(fi, CLNTC_ST_CONNECTED_CLIENT, 0, 0); @@ -180,6 +187,13 @@ osmo_fsm_inst_update_id_f(fi, "B%u", conn->bank.bank_id); osmo_fsm_inst_update_id_f(conn->keepalive_fi, "B%u", conn->bank.bank_id); + LOGPFSML(fi, LOGL_INFO, "Bankd connected from %s:%s\n", ip_str, port_str); + if (!strncmp(ip_str, "127.", 4)) { + LOGPFSML(fi, LOGL_NOTICE, "Bankd connected from %s (localhost). " + "This only works if your clients also all are on localhost, " + "as they must be able to reach the bankd!\n", ip_str); + } + /* reparent us from srv->connections to srv->banks */ pthread_rwlock_wrlock(&conn->srv->rwlock); llist_del(&conn->list); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/27947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I5446752961b039dad54aec981c1df4814779f765 Gerrit-Change-Number: 27947 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange