[S] Change in libosmocore[master]: core: fix config.h - gerrit-log

25 Feb 2026


      Attention is currently required from: Hoernchen, laforge, pespin.
fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email )
Change subject: core: fix config.h
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: 
This approach does not guard us against new files being added without including `config.h` in them. I am wondering if the goal can be achieved in a more elegant way? Maybe simply inject `-DLIBOSMOCORE_NO_LOGGING` into `CPPFLAGS`? We already inject `-DBUILDING_LIBOSMOCORE`, for instance.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 25 Feb 2026 17:07:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No