fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28727 ) Change subject: trxcon: fix NULL pointer dereference in trx_if_open() ...................................................................... trxcon: fix NULL pointer dereference in trx_if_open() Change-Id: Id40e758f6736773f7695c02bdb8974ee422b2e63 Related: CID#275253 --- M src/host/trxcon/src/trx_if.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index dd679f2..d7e28c6 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -704,14 +704,14 @@ /* Try to allocate memory */ trx = talloc_zero(trxcon, struct trx_instance); if (!trx) { - LOGPFSML(trx->fi, LOGL_ERROR, "Failed to allocate memory\n"); + LOGPFSML(trxcon->fi, LOGL_ERROR, "Failed to allocate memory\n"); return NULL; } /* Allocate a new dedicated state machine */ trx->fi = osmo_fsm_inst_alloc_child(&trx_fsm, trxcon->fi, TRX_EVENT_OFFLINE); if (trx->fi == NULL) { - LOGPFSML(trx->fi, LOGL_ERROR, "Failed to allocate an instance " + LOGPFSML(trxcon->fi, LOGL_ERROR, "Failed to allocate an instance " "of FSM '%s'\n", trx_fsm.name); talloc_free(trx); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id40e758f6736773f7695c02bdb8974ee422b2e63 Gerrit-Change-Number: 28727 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged