wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28596 )

Change subject: fixed out of bounds write to pdu_sync buffer ......................................................................

Patch Set 2:

(1 comment)

File src/conv_enc_test.c:

https://gerrit.osmocom.org/c/osmo-tetra/+/28596/comment/629541fa_5b932491 PS1, Line 338: *((uint32_t *)pdu_sync) = r;

are we sure pdu_sync is always aligned and the type-cast is safe even on architectures that don't do […]

Although the pdu_sync buffer will almost certainly be at least dword-aligned, I took your recommendation and the code now uses osmo_store32le.