Attention is currently required from: falconia, fixeria, pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email )

Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ......................................................................

Patch Set 2:

(6 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/ae389c39_b8a82383 PS2, Line 12: TCH/HS

TCH/AHS, not TCH/HS.

Done

File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/81449da0_c741db9e PS2, Line 541: AMR

Maybe say TCH/AFS rather than just AMR, for consistency.

Done

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/298e64c5_24a77de1 PS2, Line 541: * - If the channel mode is AMR, transmit a dummy with speech

And yes, as @falcon@freecalypso. […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/aac791c5_2168bf2d PS2, Line 578: dummy_facch:

Alternatively, we can move generation of dummy FACCH into a `static inline` function (`src/osmo-bts- […]

I implemented the suggestion by @pespin@sysmocom.de. Moving code to an inline function is ok with TCH/F, but not TCH/H, because there is an additional check that refers, if FACCH is not allowed at the FN of the requested bursts: "if (!sched_tchh_dl_facch_map[br->fn % 26])"

File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/edee87f2_ae025ee5 PS2, Line 453: /* - If the channel mode is TCH/HS or TCH/EFS, transmit a dummy

The overall structure of the comment after your change no longer makes sense. […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/6e6d4645_de5d7773 PS2, Line 453: TCH/EFS

If we are keeping the whole comment structure as-is (see my other comment), this part should read TC […]

Done