Attention is currently required from: falconia, fixeria, pespin.
6 comments:
Commit Message:
Patch Set #2, Line 12: TCH/HS
TCH/AHS, not TCH/HS.
Done
File src/osmo-bts-trx/sched_lchan_tchf.c:
Maybe say TCH/AFS rather than just AMR, for consistency.
Done
Patch Set #2, Line 541: * - If the channel mode is AMR, transmit a dummy with speech
And yes, as @falcon@freecalypso. […]
Done
Patch Set #2, Line 578: dummy_facch:
Alternatively, we can move generation of dummy FACCH into a `static inline` function (`src/osmo-bts- […]
I implemented the suggestion by @pespin@sysmocom.de. Moving code to an inline function is ok with TCH/F, but not TCH/H, because there is an additional check that refers, if FACCH is not allowed at the FN of the requested bursts: "if (!sched_tchh_dl_facch_map[br->fn % 26])"
File src/osmo-bts-trx/sched_lchan_tchh.c:
Patch Set #2, Line 453: /* - If the channel mode is TCH/HS or TCH/EFS, transmit a dummy
The overall structure of the comment after your change no longer makes sense. […]
Done
Patch Set #2, Line 453: TCH/EFS
If we are keeping the whole comment structure as-is (see my other comment), this part should read TC […]
Done
To view, visit change 35132. To unsubscribe, or for help writing mail filters, visit settings.