pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38997?usp=email )
Change subject: ipaccess: Assert fd is positive ......................................................................
ipaccess: Assert fd is positive
Make coverity happy. We are in a rx path from socket, so socket should be fine at that point.
Closes: Coverity CID#435266 Change-Id: I09004040107fb72b6170618a6253a6225f4351c2 --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/97/38997/1
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 5a24686..505ec3f 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -958,6 +958,7 @@
/* ping, pong and acknowledgment cases. */ struct osmo_fd tmp_ofd = { .fd = osmo_stream_cli_get_fd(cli) }; + OSMO_ASSERT(tmp_ofd.fd >= 0); ret = ipa_ccm_rcvmsg_bts_base(msg, &tmp_ofd); if (ret < 0) goto err;
-
pespin