Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428 )
Change subject: sgsn: add TC_iu_attach_encr with UEA > 0
......................................................................
Patch Set 2:
(3 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428/comment/31a802b2_1283…
PS1, Line 691: mm
It should be '_gmm_' in the context of GPRS.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428/comment/19ce2e56_1c49…
PS1, Line 691: private function f_mm_ciph_utran() runs on BSSGP_ConnHdlr
This looks more like an altstep to me rather than a
function. […]
Done
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428/comment/60281843_e215…
PS2, Line 785: alt
No need for an alt statement. As I said, you can just call it as a normal function.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a7c3b156830058c43f15f55883ea301d2d01d5f
Gerrit-Change-Number: 27428
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Mar 2022 12:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment