Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 )
Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ......................................................................
Patch Set 2:
(1 comment)
File src/libosmo-pfcp/gen__pfcp_ies_auto.c:
https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/17e11ce3_c2ecf049 PS1, Line 42: .dec_enc = "32be",
we should have enums for this imho.
gen works such that this "32be" string genereates function calls to "myproto_dec_32be()" and "myproto_enc_32be()". It is up to the individual protocol to implement these in a myproto_ies_custom.c, an enum is not applicable here.