Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31098 )
Change subject: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI ......................................................................
Patch Set 3:
(3 comments)
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/c57a0667_77557410 PS3, Line 72: /* TODO: here a new UL TBF will be created if not available yet */ I guess you kept this on purpose?
File src/rlcmac/llc_queue.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/ce80f195_3b64a251 PS3, Line 155: break; does this intentionally only break the inner loop?
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/a8480764_512d6f59 PS3, Line 196: /* rate_ctr_inc(CTR_LLC_FRAME_DROPPED); */ commented out code. remove?