Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30877 )
Change subject: ctrl: error if program forgot to initialize the ctr handler before
installing cmds
......................................................................
Patch Set 3:
(2 comments)
File src/ctrl/control_cmd.c:
https://gerrit.osmocom.org/c/libosmocore/+/30877/comment/cbdd67e3_84f2f73b
PS2, Line 25: #include <asm-generic/errno-base.h>
This was somehow without me noticing, I also noticed
it in another patch I fixed before submitting, […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/30877/comment/d38777a7_a6900486
PS2, Line 215: * the CTRL interface first by calling ctrl_handle_alloc(2)() directly
(Would be great if linter enforced the usual comment
formatting)
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30877
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf3873f33470499fed3150ff51922a36aa0f023e
Gerrit-Change-Number: 30877
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Jan 2023 17:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment