Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726 )
Change subject: build/Makefile.common.inc: unset OSMO_REPOSITORY
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726/comment/29ee67af_3cec…
PS1, Line 9: Instead of checking whether OSMO_REPOSITORY is empty, check if it has
I'm not sure I'm following the logic here. […]
Very good point! I somehow assumed removing the default will lead to problems in
other places where OSMO_REPOSITORY was used, but that's not the case. Updated the
patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: Ie21d58dd57a893a83f566eea464ab3eec82b67a4
Gerrit-Change-Number: 31726
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 15:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment