Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36815?usp=email ) Change subject: IPAd_Tests: expect TERMINAL CAPABILITIES ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ipad/IPAd_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36815/comment/f2b86091_33fb… PS1, Line 317: f_vpcd_exp(tr_VPCD_DATA('80AA000005A903830107'O)); it would be great if we could at least pust these hexstring into constants so they get a meaningful name. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0627685a300a478c39858abe1b5bb0f97f6d3fe Gerrit-Change-Number: 36815 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 17:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment